Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UBNT Airos type: wireless #6867

Merged
merged 1 commit into from Jul 13, 2017
Merged

Make UBNT Airos type: wireless #6867

merged 1 commit into from Jul 13, 2017

Conversation

trs80
Copy link
Contributor

@trs80 trs80 commented Jun 20, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Because it is. Also airos-af is type: wireless

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6867.ci.librenms.org or https://6867.ci.librenms.org

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@murrant
Copy link
Member

murrant commented Jun 20, 2017

Go ahead and change airos-af in this PR as well and create a notification like this: librenms/librenms.github.io#90

Thanks.

trs80 added a commit to trs80/librenms.github.io that referenced this pull request Jul 3, 2017
@trs80
Copy link
Contributor Author

trs80 commented Jul 3, 2017

Ah, my point was that airos-af was already type: wireless, to support my change of airos from type: network to type: wireless. Anyway, notification created.

@laf
Copy link
Member

laf commented Jul 3, 2017

@trs80 I can't see the pull request for the notification :(

@trs80
Copy link
Contributor Author

trs80 commented Jul 4, 2017

It helps when I make a pull request librenms/librenms.github.io#92

murrant pushed a commit to librenms/librenms.github.io that referenced this pull request Jul 4, 2017
@laf
Copy link
Member

laf commented Jul 4, 2017

blocker in place. please merge on the 10th of July.

@laf laf merged commit ba8fcdf into librenms:master Jul 13, 2017
@laf laf removed the Blocker 🚫 label Jul 13, 2017
@lock
Copy link

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants